Merged
Conversation
flacoman91
requested review from
anselmbradford,
billhimmelsbach,
contolini and
natalia-fitzgerald
as code owners
|
anselmbradford
approved these changes
Mar 12, 2026
Member
anselmbradford
left a comment
anselmbradford
left a comment
There was a problem hiding this comment.
If you want to go to ESLint v10 already you can set the react to 19 in https://github.com/cfpb/design-system-react/blob/main/eslint.config.js#L65 instead of detect and revert that when eslint-plugin-react is next updated.
Collaborator
Author
We should force anyone using this library to go to react 19 anyway, but im not sure if anyone else is still on 18. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
How to test this PR
Screenshots
Notes