Skip to content

573 - Multi viewport viewer addon #574

Merged
flacoman91 merged 21 commits into
mainfrom
rad-hero-fix
May 13, 2026
Merged

573 - Multi viewport viewer addon #574
flacoman91 merged 21 commits into
mainfrom
rad-hero-fix

Conversation

@flacoman91
Copy link
Copy Markdown
Collaborator

@flacoman91 flacoman91 commented May 11, 2026

Addresses- ??

Fixed the font rendering in the preview as well

I installed storybook-font-inspector so you can use the tool to inspect the fonts in a single preview
Screenshot 2026-05-12 at 5 53 10 AM

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 11, 2026

PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-05-13 19:10 UTC

@flacoman91 flacoman91 enabled auto-merge (squash) May 12, 2026 15:29
@natalia-fitzgerald
Copy link
Copy Markdown
Collaborator

natalia-fitzgerald commented May 13, 2026

@flacoman91

I took a look at all components to see how the "All viewports" is working across the board. Here's an itemized review of what I found, including suggested changes. For anything that is out of scope for this PR I can create separate tickets.

Multi viewport bugs

  • Focus state and interactive state borders getting cut off for perhaps all components that have states
  • Container for the tablet version of the Header component
  • The image in the DSR implementation of the 50/50 hero is not rendering correctly. In this hero the image should take up 50% of the hero space. You can view the implemented component here: https://www.consumerfinance.gov/es/

Checkbox

At "All viewports" focus state is getting cut off.
Image

Large target area

At "All viewports" focus state is getting cut off.
Image

Expandables

At "All viewports" focus state is getting cut off.
Image

Alert

In the field-level alerts for "All viewports" the input field border and focus state are getting cut off.
Image

Breadcrumb

For the breadcrumb at mobile, should we have 15px padding left and right? See image from CE staging:
Image

Fieldset

At "All viewports" focus state is getting cut off.
Image

Header
At "All viewports" there is extra space between tablet and phone.
Image

Layout

I'm not sure how to interpret the "All viewports" view for this one.

Select

In "All viewports" the input field border and focus state are getting cut off. This is happening for both single and multi selects.

Hero related

50/50 hero

The image in the DSR implementation of the 50/50 hero is not rendering correctly. In this hero the image should take up 50% of the hero space. You can view the implemented component here: https://www.consumerfinance.gov/es/

Screenshots

cf.gov/DS DSR implentation
Screenshot 2026-05-12 at 10 14 52 PM Screenshot 2026-05-12 at 11 24 56 PM

Pre-existing issues

Text fixes (easy fixes)

Full-width button

Change button label to "Full-width" instead of "Resize to mobile to see effect"

Alert

  • In the sample component text, match the wording and casing shown in the CFPB Design System.
  • In component text, change "A Notification" to "Information alert"
  • Remove period from "No results found" and "Page not found"
  • Remove "Link to more info" from field-level alerts
  • Change casing of placeholder text to "Input text"

Match the text shown here:
Image
Image
Image
Image

Code fixes (higher level of effort)

Icons

Icons next to headings are sitting low. I have to look into whether this is a known issue that's on the radar at the DS level. It could be related to the typeface change.

Eyebrow

https://www.consumerfinance.gov/owning-a-home/prepare/

Screenshots

DS component DSR implementation
Screenshot 2026-05-12 at 11 30 59 PM Screenshot 2026-05-12 at 11 36 12 PM
Screenshot 2026-05-12 at 11 36 12 PM

Slug

Hero

For the majority of CFPB components, we go down the the next heading level at 600px width and below. For the Hero component, however, the type styling breaks to the next level at 900px wide. This creates a conflict in visual hierarchy between the 900px and 601px width, where you will see the hero heading and the first heading in the main content area styled with the Heading 2 styling.

Screenshots

DS component DSR implentation
Screenshot 2026-05-12 at 11 19 19 PM Screenshot 2026-05-12 at 11 19 35 PM

@flacoman91 flacoman91 changed the title 573 - storybook hero and DS fixes 573 - Multi viewport viewer addon May 13, 2026
Copy link
Copy Markdown
Collaborator

@natalia-fitzgerald natalia-fitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@flacoman91
Great work on this! It looks good.

I created separate tickets for all items posted here that were not directly related to the multi-viewport addon #574 (comment)

@flacoman91 flacoman91 merged commit 6548046 into main May 13, 2026
3 checks passed
@flacoman91 flacoman91 deleted the rad-hero-fix branch May 13, 2026 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants