Update the isort example config#207
Merged
willbarton merged 2 commits intomasterfrom Jul 10, 2020
Merged
Conversation
This change updates the isort example config to remove the `not_skip` setting that was deprecated and removed in [isort 5.0](https://github.com/timothycrosley/isort/blob/5.0.0/CHANGELOG.md#500-penny---july-4-2020).
Scotchester
approved these changes
Jul 10, 2020
higs4281
reviewed
Jul 10, 2020
Member
higs4281
left a comment
higs4281
left a comment
There was a problem hiding this comment.
Could we also remove the --recursive flag at https://github.com/cfpb/development/blob/master/tox.ini#L26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the isort example config to remove the
not_skipsetting that was deprecated and removed in isort 5.0.See some additional context in cfpb/consumerfinance.gov#5840.