🐛 Fix authority header handling for HTTP/2#2522
Conversation
Signed-off-by: Alex Li <github@alexv525.com>
|
@copilot Add authority tests in the dio_test package |
Agent-Logs-Url: https://github.com/cfug/dio/sessions/7ab6cdf7-b3f4-4b5c-97f5-6ef57a306b44 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Implemented in commit I added shared authority regression coverage in |
|
@copilot The test should not only targeting H2, but as a general test about header values |
Agent-Logs-Url: https://github.com/cfug/dio/sessions/acec7f51-d150-496d-957e-721c99fc4420 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Updated in I refactored this into a general shared header-value test under |
|
@copilot Can't the test check the value directly without determining the adapter? If not, convert the test from general to the H2 adapter package only (and move under its test folder) |
Agent-Logs-Url: https://github.com/cfug/dio/sessions/b148ff7d-bfbf-4e1e-8802-68e323983f98 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Updated in I moved this regression test to |
|
Agent-Logs-Url: https://github.com/cfug/dio/sessions/3e786e59-4495-4e7a-b0a4-37a262035db5 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Addressed in I removed the unnecessary |
|
@copilot Format the test file |
Agent-Logs-Url: https://github.com/cfug/dio/sessions/f4008f24-1a56-4d9a-b040-334ce73e6082 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Done in |
|
@copilot Add changelog entry |
Agent-Logs-Url: https://github.com/cfug/dio/sessions/ec1bba1e-f157-42ce-92d3-d6bc2e0cb9d5 Co-authored-by: AlexV525 <15884415+AlexV525@users.noreply.github.com>
Done in |
Code Coverage Report: Only Changed Files listed
Minimum allowed coverage is |
Fixes #2521