Skip to content

Conversation

@cgrindel
Copy link
Owner

@cgrindel cgrindel commented Aug 26, 2023

Previously, binary targets were exposed using apple_dynamic_xcframework_import. Now, they will be exposed as apple_statix_xcframework_import.

If anyone wishes to be able control how these targets are represented in the Bazel build graph, please comment on #559.

Closes #498.

@cgrindel cgrindel self-assigned this Aug 26, 2023
Copy link

@erneestoc erneestoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to have this working.

@cgrindel cgrindel force-pushed the gh498_braze_validation_failure branch from b908db6 to 9190a4f Compare September 1, 2023 18:43
@cgrindel cgrindel changed the title Use apple_static_xcframework_import for binary targets fix: use apple_static_xcframework_import for binaryTarget in SPM Sep 1, 2023
@cgrindel cgrindel force-pushed the gh498_braze_validation_failure branch from 9190a4f to 20f6af6 Compare September 1, 2023 18:45
@cgrindel cgrindel marked this pull request as ready for review September 1, 2023 18:48
@cgrindel cgrindel enabled auto-merge (squash) September 1, 2023 18:48
Copy link

@erneestoc erneestoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@cgrindel cgrindel merged commit c386c12 into main Sep 5, 2023
@cgrindel cgrindel deleted the gh498_braze_validation_failure branch September 5, 2023 18:19
renovate bot referenced this pull request in bazel-contrib/rules_bazel_integration_test Sep 5, 2023
…197)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_swift_package_manager | bazel_dep | minor | `0.8.0` -> `0.9.0` |
|
[rules_swift_package_manager](https://togithub.com/cgrindel/rules_swift_package_manager)
| http_archive | minor | `v0.8.0` -> `v0.9.0` |

---

### Release Notes

<details>
<summary>cgrindel/rules_swift_package_manager
(rules_swift_package_manager)</summary>

###
[`v0.9.0`](https://togithub.com/cgrindel/rules_swift_package_manager/releases/tag/v0.9.0)

[Compare
Source](https://togithub.com/cgrindel/rules_swift_package_manager/compare/v0.8.0...v0.9.0)

#### What's Changed

- chore(deps): update dependency rules_xcodeproj to v1.10.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/555](https://togithub.com/cgrindel/rules_swift_package_manager/pull/555)
- chore: remove legacy WORKSPACE by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/rules_swift_package_manager/pull/556](https://togithub.com/cgrindel/rules_swift_package_manager/pull/556)
- chore(deps): update dependency cgrindel_bazel_starlib to v0.17.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/552](https://togithub.com/cgrindel/rules_swift_package_manager/pull/552)
- fix(deps): update module golang.org/x/text to v0.12.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/549](https://togithub.com/cgrindel/rules_swift_package_manager/pull/549)
- chore: update README.md for v0.8.0 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/550](https://togithub.com/cgrindel/rules_swift_package_manager/pull/550)
- chore(deps): update dependency com_github_apple_swift_argument_parser
to v1.2.3 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/514](https://togithub.com/cgrindel/rules_swift_package_manager/pull/514)
- chore(deps): update dependency nicklockwood/swiftformat to from:
"0.52.3" by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/560](https://togithub.com/cgrindel/rules_swift_package_manager/pull/560)
- fix(deps): update module golang.org/x/text to v0.13.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/561](https://togithub.com/cgrindel/rules_swift_package_manager/pull/561)
- chore(deps): update actions/checkout action to v4 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/562](https://togithub.com/cgrindel/rules_swift_package_manager/pull/562)
- fix: use `apple_static_xcframework_import` for `binaryTarget` in SPM
by [@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/rules_swift_package_manager/pull/546](https://togithub.com/cgrindel/rules_swift_package_manager/pull/546)

**Full Changelog**:
cgrindel/rules_swift_package_manager@v0.8.0...v0.9.0

#### Bazel Module Snippet

```python
bazel_dep(name = "rules_swift_package_manager", version = "0.9.0")
```

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_swift_package_manager",
    sha256 = "886f02a940d9a20fd8cbfcfd4f3b6f59379f458bb07236527fc432588beb5f52",
    urls = [
        "https://github.com/cgrindel/rules_swift_package_manager/releases/download/v0.9.0/rules_swift_package_manager.v0.9.0.tar.gz",
    ],
)

load("@&#8203;rules_swift_package_manager//:deps.bzl", "swift_bazel_dependencies")

swift_bazel_dependencies()

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

### MARK: - Gazelle
### gazelle:repo bazel_gazelle

load("@&#8203;bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("@&#8203;rules_swift_package_manager//:go_deps.bzl", "swift_bazel_go_dependencies")
load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

### Declare Go dependencies before calling go_rules_dependencies.
swift_bazel_go_dependencies()

go_rules_dependencies()

go_register_toolchains(version = "1.19.1")

gazelle_dependencies()

### MARK: - Swift Toolchain

http_archive(
    name = "build_bazel_rules_swift",

### Populate with your preferred release 
### https://github.com/bazelbuild/rules_swift/releases
)

load(
    "@&#8203;build_bazel_rules_swift//swift:repositories.bzl",
    "swift_rules_dependencies",
)
load("//:swift_deps.bzl", "swift_dependencies")

### gazelle:repository_macro swift_deps.bzl%swift_dependencies
swift_dependencies()

swift_rules_dependencies()

load(
    "@&#8203;build_bazel_rules_swift//swift:extras.bzl",
    "swift_rules_extra_dependencies",
)

swift_rules_extra_dependencies()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43OS4xIiwidXBkYXRlZEluVmVyIjoiMzYuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cgrindel referenced this pull request in k1nkreet/rules_bazel_integration_test Sep 27, 2023
…azel-contrib#197)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_swift_package_manager | bazel_dep | minor | `0.8.0` -> `0.9.0` |
|
[rules_swift_package_manager](https://togithub.com/cgrindel/rules_swift_package_manager)
| http_archive | minor | `v0.8.0` -> `v0.9.0` |

---

### Release Notes

<details>
<summary>cgrindel/rules_swift_package_manager
(rules_swift_package_manager)</summary>

###
[`v0.9.0`](https://togithub.com/cgrindel/rules_swift_package_manager/releases/tag/v0.9.0)

[Compare
Source](https://togithub.com/cgrindel/rules_swift_package_manager/compare/v0.8.0...v0.9.0)

#### What's Changed

- chore(deps): update dependency rules_xcodeproj to v1.10.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/555](https://togithub.com/cgrindel/rules_swift_package_manager/pull/555)
- chore: remove legacy WORKSPACE by
[@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/rules_swift_package_manager/pull/556](https://togithub.com/cgrindel/rules_swift_package_manager/pull/556)
- chore(deps): update dependency cgrindel_bazel_starlib to v0.17.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/552](https://togithub.com/cgrindel/rules_swift_package_manager/pull/552)
- fix(deps): update module golang.org/x/text to v0.12.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/549](https://togithub.com/cgrindel/rules_swift_package_manager/pull/549)
- chore: update README.md for v0.8.0 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/550](https://togithub.com/cgrindel/rules_swift_package_manager/pull/550)
- chore(deps): update dependency com_github_apple_swift_argument_parser
to v1.2.3 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/514](https://togithub.com/cgrindel/rules_swift_package_manager/pull/514)
- chore(deps): update dependency nicklockwood/swiftformat to from:
"0.52.3" by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/560](https://togithub.com/cgrindel/rules_swift_package_manager/pull/560)
- fix(deps): update module golang.org/x/text to v0.13.0 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/561](https://togithub.com/cgrindel/rules_swift_package_manager/pull/561)
- chore(deps): update actions/checkout action to v4 by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/562](https://togithub.com/cgrindel/rules_swift_package_manager/pull/562)
- fix: use `apple_static_xcframework_import` for `binaryTarget` in SPM
by [@&#8203;cgrindel](https://togithub.com/cgrindel) in
[https://github.com/cgrindel/rules_swift_package_manager/pull/546](https://togithub.com/cgrindel/rules_swift_package_manager/pull/546)

**Full Changelog**:
cgrindel/rules_swift_package_manager@v0.8.0...v0.9.0

#### Bazel Module Snippet

```python
bazel_dep(name = "rules_swift_package_manager", version = "0.9.0")
```

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_swift_package_manager",
    sha256 = "886f02a940d9a20fd8cbfcfd4f3b6f59379f458bb07236527fc432588beb5f52",
    urls = [
        "https://github.com/cgrindel/rules_swift_package_manager/releases/download/v0.9.0/rules_swift_package_manager.v0.9.0.tar.gz",
    ],
)

load("@&#8203;rules_swift_package_manager//:deps.bzl", "swift_bazel_dependencies")

swift_bazel_dependencies()

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

### MARK: - Gazelle
### gazelle:repo bazel_gazelle

load("@&#8203;bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("@&#8203;rules_swift_package_manager//:go_deps.bzl", "swift_bazel_go_dependencies")
load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

### Declare Go dependencies before calling go_rules_dependencies.
swift_bazel_go_dependencies()

go_rules_dependencies()

go_register_toolchains(version = "1.19.1")

gazelle_dependencies()

### MARK: - Swift Toolchain

http_archive(
    name = "build_bazel_rules_swift",

### Populate with your preferred release 
### https://github.com/bazelbuild/rules_swift/releases
)

load(
    "@&#8203;build_bazel_rules_swift//swift:repositories.bzl",
    "swift_rules_dependencies",
)
load("//:swift_deps.bzl", "swift_dependencies")

### gazelle:repository_macro swift_deps.bzl%swift_dependencies
swift_dependencies()

swift_rules_dependencies()

load(
    "@&#8203;build_bazel_rules_swift//swift:extras.bzl",
    "swift_rules_extra_dependencies",
)

swift_rules_extra_dependencies()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi43OS4xIiwidXBkYXRlZEluVmVyIjoiMzYuNzkuMSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

App with binary dependency fails ASC validation

4 participants