Skip to content

feat: add support for .enableExperimentalFeature() #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 17, 2023
Merged

feat: add support for .enableExperimentalFeature() #660

merged 3 commits into from
Oct 17, 2023

Conversation

@jpsim
Copy link
Collaborator

@jpsim jpsim commented Oct 16, 2023

This fixes the swift-atomics package.

@jpsim
Add support for .enableExperimentalFeature()
4f63fe0 
This fixes the `swift-atomics` package.
@cgrindel cgrindel changed the title Add support for .enableExperimentalFeature() feat: add support for .enableExperimentalFeature() Oct 16, 2023
@cgrindel
Copy link
Owner

cgrindel commented Oct 16, 2023

Is there something that we can add to the examples that will exercise this?

@cgrindel
Copy link
Owner

cgrindel commented Oct 16, 2023

Is this PR to support this flag?

@cgrindel
Copy link
Owner

cgrindel commented Oct 16, 2023

Instead of adding it to an example, perhaps we can add a test in swiftpkg_build_files_tests.bzl.

@jpsim
Copy link
Collaborator Author

jpsim commented Oct 16, 2023

Is this PR to support this flag?

Yes

Instead of adding it to an example, perhaps we can add a test in swiftpkg_build_files_tests.bzl.

I'll take a look.

@cgrindel cgrindel enabled auto-merge (squash) October 17, 2023 13:06
@cgrindel cgrindel merged commit eee50eb into cgrindel:main Oct 17, 2023
@jpsim jpsim deleted the add-support-for-.enableexperimentalfeature branch October 17, 2023 14:47
renovate bot referenced this pull request in bazel-contrib/rules_bazel_integration_test Oct 18, 2023
@renovate
chore(deps): update dependency rules_swift_package_manager to v0.16.0 (…
34d9378 
…#221)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| rules_swift_package_manager | bazel_dep | minor | `0.15.0` -> `0.16.0`
|
|
[rules_swift_package_manager](https://togithub.com/cgrindel/rules_swift_package_manager)
| http_archive | minor | `v0.15.0` -> `v0.16.0` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>cgrindel/rules_swift_package_manager
(rules_swift_package_manager)</summary>

###
[`v0.16.0`](https://togithub.com/cgrindel/rules_swift_package_manager/releases/tag/v0.16.0)

[Compare
Source](https://togithub.com/cgrindel/rules_swift_package_manager/compare/v0.15.0...v0.16.0)

#### What's Changed

- chore: update README.md for v0.15.0 by
[@&#8203;cgrindel-app-token-generator](https://togithub.com/cgrindel-app-token-generator)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/659](https://togithub.com/cgrindel/rules_swift_package_manager/pull/659)
- chore(deps): update dependency nicklockwood/swiftformat to from:
"0.52.8" by
[@&#8203;cgrindel-self-hosted-renovate](https://togithub.com/cgrindel-self-hosted-renovate)
in
[https://github.com/cgrindel/rules_swift_package_manager/pull/662](https://togithub.com/cgrindel/rules_swift_package_manager/pull/662)
- feat: add support for `.enableExperimentalFeature()` by
[@&#8203;jpsim](https://togithub.com/jpsim) in
[https://github.com/cgrindel/rules_swift_package_manager/pull/660](https://togithub.com/cgrindel/rules_swift_package_manager/pull/660)

#### New Contributors

- [@&#8203;jpsim](https://togithub.com/jpsim) made their first
contribution in
[https://github.com/cgrindel/rules_swift_package_manager/pull/660](https://togithub.com/cgrindel/rules_swift_package_manager/pull/660)

**Full Changelog**:
cgrindel/rules_swift_package_manager@v0.15.0...v0.16.0

#### Bazel Module Snippet

```python
bazel_dep(name = "rules_swift_package_manager", version = "0.16.0")
```

#### Workspace Snippet

```python
load("@&#8203;bazel_tools//tools/build_defs/repo:http.bzl", "http_archive")

http_archive(
    name = "rules_swift_package_manager",
    sha256 = "4b1b1dec2d172a688cc0266b3b8b70a8c92f53a5e824bfaadb0f91c3a351b6fc",
    urls = [
        "https://github.com/cgrindel/rules_swift_package_manager/releases/download/v0.16.0/rules_swift_package_manager.v0.16.0.tar.gz",
    ],
)

load("@&#8203;rules_swift_package_manager//:deps.bzl", "swift_bazel_dependencies")

swift_bazel_dependencies()

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

### MARK: - Gazelle
### gazelle:repo bazel_gazelle

load("@&#8203;bazel_gazelle//:deps.bzl", "gazelle_dependencies")
load("@&#8203;rules_swift_package_manager//:go_deps.bzl", "swift_bazel_go_dependencies")
load("@&#8203;io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies")

### Declare Go dependencies before calling go_rules_dependencies.
swift_bazel_go_dependencies()

go_rules_dependencies()

go_register_toolchains(version = "1.19.1")

gazelle_dependencies()

### MARK: - Swift Toolchain

http_archive(
    name = "build_bazel_rules_swift",

### Populate with your preferred release 
### https://github.com/bazelbuild/rules_swift/releases
)

load(
    "@&#8203;build_bazel_rules_swift//swift:repositories.bzl",
    "swift_rules_dependencies",
)
load("//:swift_deps.bzl", "swift_dependencies")

### gazelle:repository_macro swift_deps.bzl%swift_dependencies
swift_dependencies()

swift_rules_dependencies()

load(
    "@&#8203;build_bazel_rules_swift//swift:extras.bzl",
    "swift_rules_extra_dependencies",
)

swift_rules_extra_dependencies()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/bazel-contrib/rules_bazel_integration_test).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xOS4yIiwidXBkYXRlZEluVmVyIjoiMzcuMTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgrindel cgrindel cgrindel approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jpsim @cgrindel