Add PhotoRec image minimum filters#207
Closed
gero-studios wants to merge 1 commit into
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #167.
This adds configurable image minimum filters for PhotoRec:
/cmdoption parsing and session save outputI noticed #206 after starting this implementation. This PR is offered as an alternative, mainly because it also exposes the controls in QPhotoRec and checks JPEG dimensions again after validation if the SOF marker was not available in the initial header buffer. If maintainers prefer #206, I am happy to close this.
Verification:
git diff --checkgcc -fsyntax-only -I src -DHAVE_STDINT_H -DHAVE_INTTYPES_H -DHAVE_SYS_TYPES_H -DHAVE_SYS_STAT_H -DHAVE_STRING_H -DHAVE_TIME_H -DHAVE_STDLIB_H src/filegen.c src/poptions.c src/photorec.c src/sessionp.c src/phrecn.c src/file_png.c src/file_jpg.cI could not run the full autotools build in this Windows workspace because generated configure files are not present and the portable toolchain used for verification does not include autotools.