Setup Node.js in release workflow#2010
Merged
Merged
Conversation
Pin the version from `package.json` so the release stays in sync with engines.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub Actions runners don't honor the
engines.nodefield frompackage.json. Since the bump to>=22.22.1, the release workflow keeps running with the runner's default Node, which no longer satisfies the constraint —npm ciandnpm run buildfail, and no artifact is produced.Solution
Add an explicit
actions/setup-node@v6step that reads the version frompackage.json, so the release runtime stays aligned withengines.