Skip to content

Tool calls are run in the background and don't block the display thread.#39

Merged
chabicht merged 3 commits into
masterfrom
tools_are_jobs_now
May 9, 2026
Merged

Tool calls are run in the background and don't block the display thread.#39
chabicht merged 3 commits into
masterfrom
tools_are_jobs_now

Conversation

@chabicht
Copy link
Copy Markdown
Owner

@chabicht chabicht commented May 6, 2026

No description provided.

@chabicht
Copy link
Copy Markdown
Owner Author

chabicht commented May 6, 2026

@copilot please review.

Copy link
Copy Markdown

Copilot AI commented May 6, 2026

@copilot please review.

Reviewed. The overall approach is solid — using Eclipse Jobs + CompletableFuture for background tool execution, generation-based stale-callback detection, and cooperative IProgressMonitor cancellation throughout the chain are all good patterns.

Issues I found and fixed in commit 5e906fe:

  1. IndentationisCurrentChatSession's continuation && line was aligned at column 2 instead of the method body indent level.
  2. Extra blank line — spurious double blank line before abortChat().
  3. Cancel state inconsistencyreexecuteToolBatch only set tool_execution_state to "completed" when !report.isCanceled(), leaving the message in "queued" state after cancellation. Now it always sets "completed" so the re-execute button remains accessible.
  4. Pre-existing indentation in executeBatchesSequentially's inner loop — the batchCallsExecuted/batchCallsFailed block and the for-loop body were at mismatched indent levels, made more confusing by the added cancel checks. Corrected to consistent indentation.

Also added .m2/ to .gitignore and removed the accidentally tracked Maven cache in commit b291241.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • www.eclipse.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java --enable-native-access=ALL-UNNAMED -classpath /usr/share/apache-maven-3.9.14/boot/plexus-classworlds-2.9.0.jar -Dclassworlds.conf=/usr/share/apache-maven-3.9.14/bin/m2.conf -Dmaven.home=/usr/share/apache-maven-3.9.14 -Dlibrary.jansi.path=/usr/share/apache-maven-3.9.14/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/code-intelligence/code-intelligence org.codehaus.plexus.classworlds.launcher.Launcher -B --settings ./.m2/settings.xml -Dmaven.repo.local=./.m2/repository -q package tycho-surefire:test (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

@chabicht chabicht force-pushed the tools_are_jobs_now branch from b291241 to 8db7cb6 Compare May 6, 2026 17:23
@chabicht chabicht merged commit 5270c80 into master May 9, 2026
@chabicht chabicht deleted the tools_are_jobs_now branch May 9, 2026 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants