docs(conformance): name WPT suites after upstream .any.js runners#4
Merged
Conversation
Rename suite titles from project-coined labels ("Data corpus",
"hasRegExpGroups semantics", etc.) to the upstream WPT runner basenames
(``urlpattern.any.js``, ``urlpattern-hasregexpgroups.any.js``, …) so a
WHATWG / WPT contributor browsing this repo can map our conformance
rows to upstream test files at a glance.
While here, surface the pinned ``WPT_REF`` SHA in the report header
(read from the corpus checkout's ``HEAD`` so it can never disagree with
what was actually tested), pin per-suite source links to that SHA, and
fix a pre-existing broken link for the constructor suite — the old
template assumed every source file lived in
``urlpattern/resources/``, which isn't true for ``.any.js`` runners
that live at ``urlpattern/<runner>.any.js``.
``SuiteResult`` gains ``runner_path`` + ``data_path`` (replacing
``source``); per-suite section now reads ``Runner: … · Data: …`` with
both URLs, or just ``Runner:`` for the constructor (cases are inline
in the runner). README's conformance table renames the "Suite" column
to "WPT runner" with the data file in its own column.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rename suite titles to upstream WPT runner basenames so a WHATWG / WPT contributor recognizes them on sight:
urlpattern.any.jsurlpattern-constructor.any.jsurlpattern-hasregexpgroups.any.jsurlpattern-compare.tentative.any.jsurlpattern-generate.tentative.any.jsThree secondary improvements:
git -C reference/wpt rev-parse HEADso it can never disagree with the bytes actually tested.master). A committee member reading the report a year from now still sees the exact files we ran against.urlpattern/resources/<file>, but.any.jsrunners live aturlpattern/<file>.any.js. New shape:Runner: <runner-url>+ optional· Data: <data-url>.Test plan
just compliance-reportregeneratesdocs/wpt-compliance.mdwith new names, pinned URLs, fixed constructor linkjust checkpasses (16 lint tools + 580 tests)