image tools: event handlers should not return 'false' when it's disabled or toolData is unavailable - #190
Merged
Conversation
…led or toolData is unavailable jquery stops the event propagation when 'false' is returned and this can break the UI.
lscoder
added a commit
to OHIF/Viewers
that referenced
this pull request
Mar 8, 2017
…led or toolData is unavailable (PR #190) Pull request cornerstonejs/cornerstoneTools#190
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jquery stops the event propagation when 'false' is returned and this can break the UI.