-
Notifications
You must be signed in to change notification settings - Fork 362
docs/internal: unify historical package branches #670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dominic
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me. I'd be interested in bikeshedding on the branch names. Something like:
release-1.0
release-1.1
1.0-stable
1.1-stable
chain-1.0
chain-1.1
|
Re: naming, I'm down for whatever. Among those choices, |
|
I like that |
|
On the topic of naming things and "say what you mean", the word "minor" sounds weird to me for our versioning scheme. Our releases like 1.1 or 1.2 are a pretty big deal. But that's beyond the scope of this PR. |
|
I just made an update recommending that we use There is a weird edge case if there are changes to other packages (such as the SDK) that precede the |
|
Also, re-constructing the |
Yeah we should make it a rule to avoid that situation. Like we should close the tree leading up to a (so-called) minor release 1.n and don't open the tree for n+1 development until everything is clear. |
00385c3 to
e8fb4e6
Compare
I've seen other repos branch early into |
|
I'm not sure what branching early buys us. We'll just have a tone of commits on the candidate branch and almost none on main during that period. If possible, I'd rather we do the stabilization work leading up to a release directly on main, rather than splitting our attention between the upcoming release and future development. In other words, it's something I'd hope we would do as a team anyway even aside from all the branching mechanics. It's less confusing if we make sure not to begin future dev work until the release is out the door. |
No description provided.