protocol/bc: add SpendCommitment type #677
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobg
reviewed
Mar 2, 2017
| control_program, confirmed_in, source_id, source_pos, ref_data_hash) | ||
| SELECT unnest($1::bytea[]), unnest($2::bigint[]), unnest($3::bytea[]), unnest($4::bytea[]), unnest($5::bigint[]), | ||
| unnest($6::text[]), unnest($7::bigint[]), unnest($8::bytea[]), $9 | ||
| ON CONFLICT (tx_hash, index) DO NOTHING |
Contributor
There was a problem hiding this comment.
Why did we lose the ON CONFLICT clause? It's still present in #665
bobg
approved these changes
Mar 2, 2017
Contributor
|
LGTM |
Spend TxInputs need to contain all of the data necessary to reconstruct output ids in order to spend them. Performing the hashing during validation gives us cryptographic integrity that the spent output data is correct. In order to preserve this data, the mapping process was updated to return additional information which is stored in the account_utxos table. This data is then populated in a SpendCommitment type on the TxInput structs.
iampogo
force-pushed
the
1.1-spent-output
branch
from
431cf42 to
6b5b4a6
Compare
iampogo
pushed a commit
that referenced
this pull request
Mar 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Spend TxInputs need to contain all of the data necessary to reconstruct
output ids in order to spend them. Performing the hashing during
validation gives us cryptographic integrity that the spent output data
is correct.
In order to preserve this data, the mapping process was updated to
return additional information which is stored in the account_utxos
table. This data is then populated in a SpendCommitment type on the
TxInput structs.
1.1-stable version of #665