sdk/java: increase index to core url monotically #727
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boymanjor
changed the title
Contributor
|
I'm not 100% sure about the description. This one is a bit subtle so it could prob use a little more explanation. |
boymanjor
changed the title
kr
approved these changes
Mar 8, 2017
Contributor
|
LGTM |
boymanjor
added a commit
that referenced
this pull request
Mar 9, 2017
The client keeps a list of core URLs which it uses to load balance requests to the server. An index is kept corresponding to a position in this list. When an error occurs the index is increased. Previously, it was possible for separate requests to read the same index and increase it separately. We have updated the logic to mitigate this by finding the position in the list (performing the modulo operation) just before a request is made. Closes #727
iampogo
pushed a commit
that referenced
this pull request
Mar 9, 2017
The client keeps a list of core URLs which it uses to load balance requests to the server. An index is kept corresponding to a position in this list. When an error occurs the index is increased. Previously, it was possible for separate requests to read the same index and increase it separately. We have updated the logic to mitigate this by finding the position in the list (performing the modulo operation) just before a request is made. Closes #727
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client keeps a list of core URLs which it uses
to load balance requests to the server. An index
is kept corresponding to a position in this list. When
an error occurs the index is increased.
Previously, it was possible for separate requests to
read the same index and increase it separately. We have
updated the logic to mitigate this by finding the position
in the list (performing the modulo operation) just before
a request is made.