OKO-498 #144
Merged
OKO-498 #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eldenpark
reviewed
Dec 24, 2025
| @@ -1,10 +1,10 @@ | |||
| -- public.key_shares definition | |||
| -- public.2_key_shares definition | |||
Collaborator
There was a problem hiding this comment.
this file will be deleted
eldenpark
reviewed
Dec 24, 2025
| }); | ||
| } | ||
|
|
||
| await knex.raw(` |
Collaborator
There was a problem hiding this comment.
Wouldn't it be safer to define this using table.index? (curious your thoughts)
Contributor
Author
There was a problem hiding this comment.
Wouldn't it be safer to define this using table.index? (curious)
table.index() doesn’t support WHERE clauses, so it can’t be used to define partial indexes
Collaborator
There was a problem hiding this comment.
https://knexjs.org/guide/schema-builder.html#index
Looks like we could, see "predicate". But raw SQL is also okay. No action required as of now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)