Conversation
email_template_2: add oko wallet email template
* oko_attached: Use CSS gradients for Base sponsorship background * oko_attached: Attach tooltip to icon wrapper and adjust styles * oko_attached: Use tertiary background for sponsored fee tooltip * oko_attached: prevent sponsored fee UI from showing when balance is sufficient for fee * oko_attached: fix fee calculation to use actual gas estimation and wait for L1 fee on OP Stack chains * oko_attached: hide next free transaction timer during signing and show keep window open message on success * oko_attached: Refetch fee sponsorship query every 10s * oko_attached: Refetch status on fee sponsorship error * oko_attached: Clamp remainingMs to not increase on update * oko_attached: Move tx receipt waiting into sponsorship flow * oko_attached: Use CSS classes for sponsorship backgrounds * oko_attached: Use viem Hex type for tx hash
|
@eldenpark Ready for review |
|
|
||
| const LOG_PREFIX = "[attached][telegram_reauth]"; | ||
|
|
||
| export function TelegramReauth() { |
There was a problem hiding this comment.
Could you define this component using the const variable assignment expression? Also the rest of the files
| // re-auth completed → popup close is expected, don't reject | ||
| } | ||
| }, 1000); | ||
| void resPromise.finally(() => window.clearInterval(timer)); |
There was a problem hiding this comment.
I really like the use of finally() here and after
| type ReAuthCredentials, | ||
| } from "./export_reauth_state"; | ||
|
|
||
| type ExportPrivateKeyError = |
There was a problem hiding this comment.
If this were to become the contents of "payload" then I'd suggest we move this up to a common dep. What's your thought? Please let me know if this isn't clear
There was a problem hiding this comment.
Since this message is only callable from the user dashboard, I think keeping the types defined locally is more appropriate, same as get_connected_apps.ts.
There was a problem hiding this comment.
Yes, but UD is still technically an "external" app that will consume this type. I'll modify this a little bit. I'll take a look at get_connected_apps as well. (but might not work on that for this PR, though)
|
@eldenpark Addressed the comments |
eldenpark
left a comment
eldenpark
left a comment
There was a problem hiding this comment.
I've taken in charge. Will touch a little
4 participants
Pull Request
CONTRIBUTING.mdand followed the guidelines.Summary
Links (Issue References, etc, if there's any)