Skip to content

workflows: route Vercel environment based on git tag prefix (OKO-633)#282

Merged
eldenpark merged 2 commits intodevelopfrom
OKO-633
Feb 23, 2026
Merged

workflows: route Vercel environment based on git tag prefix (OKO-633)#282
eldenpark merged 2 commits intodevelopfrom
OKO-633

Conversation

@lidarbtc
Copy link
Copy Markdown
Contributor

Pull Request

Thank you for raising a Pull Request. Please follow the instruction.

  • I’ve read CONTRIBUTING.md and followed the guidelines.

Summary

Links (Issue References, etc, if there's any)

- name: Build SDK packages
run: yarn ci build_sdk

- name: Determine deploy environment
Copy link
Copy Markdown
Contributor

@eldenpark eldenpark Feb 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we define this script in the TS (JS) script and reuse it in different workflows?

Example: https://github.com/chainapsis/oko/blob/develop/internals/github/src/validate_git_tag.ts

Copy link
Copy Markdown
Contributor

@eldenpark eldenpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please let me know if you have different thoughts!

@eldenpark
Copy link
Copy Markdown
Contributor

@lidarbtc I'll chime in

@lidarbtc
Copy link
Copy Markdown
Contributor Author

Fixed it.

@eldenpark
Copy link
Copy Markdown
Contributor

eldenpark commented Feb 23, 2026

@lidarbtc I'll chime in

@lidarbtc, were you able to test this out using "nektos", locally? In hindsight, I realized my suggestion actually introduces a complexity because I believe you can only retrieve a single outcome from the script executution from GH action.

@lidarbtc
Copy link
Copy Markdown
Contributor Author

@lidarbtc I'll chime in

@lidarbtc, were you able to test this out using "nektos", locally? In hindsight, I realized my suggestion actually introduces a complexity because I believe you can only retrieve a single outcome from the script executution from GH action.

However, since there will likely be occasional testing needs going forward, I'll set it up and give it a try. Thanks for the suggestion.

@eldenpark
Copy link
Copy Markdown
Contributor

eldenpark commented Feb 23, 2026

@lidarbtc Yes, so essentially using "script" to set up not just a single, but multiple env variables would not work as we expect. I'll modfiy this action a little bit shortly!

EDIT: You might be right. I'll test it out

@eldenpark eldenpark merged commit 89721fe into develop Feb 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants