fix: rename version to version.txt for release-please auto-bump#7
Merged
fix: rename version to version.txt for release-please auto-bump#7
Conversation
8 tasks
lxcong
added a commit
that referenced
this pull request
Apr 23, 2026
## Summary Removes `archive/` entirely and syncs all doc references. Archive held historical code from the pre-public-release era: - `archive/cli/` — old `@agentkey/cli` workspace (retired; superseded by `npx skills add chainbase-labs/agentkey`) - `archive/scripts/` — `inject.sh`, `install-openclaw.sh`, `setup-key.sh`, and the old `release.sh` (retired; superseded by release-please) - `archive/docs/` — OPENCLAW_INSTALL, QA checklists, QA report from the pre-1.0 flow - `archive/pnpm-workspace.yaml`, `archive/pnpm-lock.yaml`, `archive/README.md` — retired pnpm workspace scaffold None of it is referenced from active code. History is preserved in git (visible via `git log --diff-filter=D --summary` or `git show <commit>:archive/path`) for anyone who needs to look back. ## Incidental cleanup (same PR) The directory tree snippets in `README.md` and `docs/README_zh.md` were stale (they still listed `scripts/release.sh` and called `version` a "release.sh-managed" file). Updated to reflect: - `release.sh` is gone (release-please took over) - `version` → `version.txt` (renamed in #7) - Release docs now describe the release-please flow instead of the old `./scripts/release.sh patch/minor/major` invocation `.claude/CLAUDE.md` similarly updated: dropped the `archive/` directory-tree line, the `archive/` paragraph, and the "re-add OpenClaw" bullet. `.github/workflows/claude-pr-review.yml` had a convention rule `archive/** — retired code` which is vacuously true now; removed so the prompt stays accurate. ## Expected Claude reviewer behavior The reviewer should flag this PR as⚠️ Convention violation on the grounds that `version.txt` / `CHANGELOG.md` / release-please-managed files shouldn't be touched directly — but **none of those are modified** in this PR. The reviewer should produce a clean ✅ or Suggestion-level output at worst. This PR is partially a live test of the reviewer: - Did the `Claude` GitHub App install + `ANTHROPIC_API_KEY` secret get set up? If yes, we'll see a `🤖 Claude security review` comment. - If the comment never appears, the setup is incomplete (ACTION REQUIRED: maintainer). ## Test plan - [x] `git rm -r archive/` — 69 files removed - [x] No active code references `archive/` anymore (verified: `grep -rn 'archive/' --exclude-dir=.git` is empty) - [x] Both READMEs' directory trees updated - [x] CLAUDE.md scrubbed - [x] Workflow YAML still valid (`python3 -c "import yaml; yaml.safe_load(...)"`) - [x] PR title conventional; commitlint should pass - [ ] Post-merge: no user-facing impact (archive was never shipped as installable content) - [ ] Post-merge: this is a `chore:` so release-please should NOT open a release PR --------- Co-authored-by: lxcong <lxhtheresa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Release-please PR #6 (bumping to v1.1.0) revealed that the
versionfile wasn't being auto-updated —plugin.json,CHANGELOG.md, and.release-please-manifest.jsonall bumped correctly, butversionstayed at1.0.0.Root cause: the
genericextra-files updater requires# x-release-please-versionanchor markers in the file. Ourversionfile is a bare version string with no markers, so release-please silently skipped it.Consequence if left unfixed:
check-update.shreadsversionto compare with remote releases — users would see "UPDATED: v1.1.0" on every skill invocation after v1.1.0 publishes, because the localversionfile never advances.Fix
version→version.txt. Thesimplerelease-type in release-please auto-managesversion.txtby convention, no extra-files entry needed.{"type": "generic", "path": "version"}entry fromrelease-please-config.json.check-update.shVERSION_FILE pointer.version.txtto1.1.0so it matches what PR chore(main): release agentkey-skill 1.1.0 #6 will cut.Merge order
This PR first, then release PR #6. Release-please will see
version.txt=1.1.0already in place and leave it alone;plugin.jsonwill still bump from 1.0.0 → 1.1.0 as usual.Test plan
python3 -c "import json; json.load(open('release-please-config.json'))"OKbash -n skills/agentkey/scripts/check-update.shOKgit mvpreserves historygit show v1.1.0:version.txtequals1.1.0