Skip to content

fix: add access lists, fix: RLP on contract creation transactions #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merklefruit merged 2 commits into from
Nov 13, 2023
Merged

fix: add access lists, fix: RLP on contract creation transactions #8

merklefruit merged 2 commits into from
Nov 13, 2023

Conversation

@merklefruit
Copy link
Contributor

@merklefruit merklefruit commented Nov 9, 2023 •
edited
Loading

This PR fixes two bugs:

  1. ToNative didn't have support for AccessList
  2. ProtoToTx mistakenly set address to 0x0000...000 instead of nil for contract creation txs

@merklefruit merklefruit changed the title fix: add access list to serialization fix: add access list to native serialization function Nov 9, 2023
@merklefruit merklefruit changed the title fix: add access list to native serialization function fix: add access list in ToNative(), fix RLP on contract creation transactions Nov 13, 2023
@merklefruit merklefruit self-assigned this Nov 13, 2023
@merklefruit merklefruit added the bug Something isn't working label Nov 13, 2023
@merklefruit merklefruit changed the title fix: add access list in ToNative(), fix RLP on contract creation transactions fix: add access lists, fix: RLP on contract creation transactions Nov 13, 2023
mempirate
mempirate approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mempirate mempirate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, good catches!

@merklefruit merklefruit merged commit 12f1403 into main Nov 13, 2023
@merklefruit merklefruit deleted the fix/acl branch November 13, 2023 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mempirate mempirate mempirate approved these changes

Assignees

@merklefruit merklefruit

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@merklefruit @mempirate