Skip to content
This repository was archived by the owner on Dec 19, 2024. It is now read-only.

add ci and general update/refactor#3

Merged
wlynch merged 4 commits intomainfrom
ci
Mar 7, 2023
Merged

add ci and general update/refactor#3
wlynch merged 4 commits intomainfrom
ci

Conversation

@cpanato
Copy link
Member

@cpanato cpanato commented Mar 7, 2023

The code refactor was to get rid of the lint complaint:

main.go:37:5: exitAfterDefer: log.Fatalf will exit, and `defer os.RemoveAll(tmp)` will not run (gocritic)
                                log.Fatalf("could not clone repo: %s %s", err, string(out))
                                ^

in a nice way, but if you dont like it i can revert

@cpanato cpanato requested a review from wlynch March 7, 2023 14:15
@wlynch wlynch merged commit ed63dd9 into main Mar 7, 2023
@cpanato cpanato deleted the ci branch March 7, 2023 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments