Tune concurrency and scanFD#1078
Merged
Merged
Conversation
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
reviewed
Aug 11, 2025
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
eslerm
approved these changes
Aug 12, 2025
eslerm
approved these changes
Aug 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some minor tweaks to how per-scan concurrency is handled along with the
scanFDmethod which was duplicating size calculations.While it shouldn't matter too much, we can cap the concurrency for processing standard file paths along with extracted file paths so that we don't just use the configured concurrency value everywhere.
We still need to create a 1:1 pool of scanners to available CPUs since we use the pool for the duration of a
malrun which may execute concurrent scans of single files (likemake refresh-sample-testdata).