Small archive extraction fixes; support bzip2 archives#479
Merged
egibs merged 2 commits intochainguard-dev:mainfrom Oct 2, 2024
Merged
Small archive extraction fixes; support bzip2 archives#479egibs merged 2 commits intochainguard-dev:mainfrom
egibs merged 2 commits intochainguard-dev:mainfrom
Conversation
egibs
commented
Oct 2, 2024
| if err != nil { | ||
| return fmt.Errorf("failed to seek to start: %w", err) | ||
| } | ||
| br := bzip2.NewReader(tf) |
Member
Author
There was a problem hiding this comment.
It's weird that bzip2.NewReader only returns an io.Reader instead of (io.Reader, err). It would be nice to do some error checking like we do with gzip.NewReader. 😞
Signed-off-by: egibs <20933572+egibs@users.noreply.github.com>
tstromberg
approved these changes
Oct 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We noticed a few issues around extracting archives and I also noticed that we never added bzip2 support.
This PR:
.apk,.gz, and.tar.gzfiles (that statement never rantf.Seek(0, io.SeekStart)) by moving the seek code out of the switch statementsio.ErrUnexpectedEOFwhen iterating through thetarreaderbzip2archive support