Add a hook to run shellcheck on all "runs" steps in melange pipelines#2
Merged
Add a hook to run shellcheck on all "runs" steps in melange pipelines#2
Conversation
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
This is really intended to be an example for other repos. Rename it to make that more obvious, and also make room for us to add a working .pre-commit-config.yaml to this repo. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
@techalchemy says this is the what the cool kids are doing. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Stolen from upstream pre-commit-hooks repo. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Allow users to override the shellcheck executable. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Requires that temp files live in the current directory, as that is what will be mounted within the container. We should replace this with a guarded container. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
We can pass all run steps to one instance of shellcheck. This should be faster. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
For easier debugging. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Fewer lines, and clearer. Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
Signed-off-by: dann frazier <dann.frazier@chainguard.dev>
dannf
changed the title
Signed-off-by: Amber Arcadia <amber.arcadia@chainguard.dev>
Signed-off-by: Amber Arcadia <amber.arcadia@chainguard.dev>
AmberArcadia
approved these changes
May 20, 2025
Member
AmberArcadia
left a comment
AmberArcadia
left a comment
There was a problem hiding this comment.
Looking good! I made a few minor tweaks and notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also include pre-commit configuration for the files in this repo.