feat(jsonschema): Generate jsonschema for workflowcontract proto #1281
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
reviewed
Aug 29, 2024
app/controlplane/Makefile
Outdated
| cd ./plugins/sdk/v1/plugin/api && buf generate | ||
| cd ./api && buf generate | ||
| # Remove all json schema that are not part of the workflowcontract since we don't need them | ||
| find ./api/gen/jsonschema -type f ! -name 'workflowcontract.*' -exec rm {} + |
Member
There was a problem hiding this comment.
mm, I am not sure this is correct. in the CI we might be running generation without makefile, and afaik we are not enforcing using make for things
What's wrong with having all the files? How many are those?
Member
Author
There was a problem hiding this comment.
There are 189 generated files without the option of not generating them.
| - outputClientImpl=grpc-web # client implementation it generates | ||
| - esModuleInterop=true # use imports as required in modern ts setups | ||
| - useOptionals=messages # use optional TypeScript properties instead of undefined | ||
| - plugin: buf.build/bufbuild/protoschema-jsonschema |
Member
There was a problem hiding this comment.
can you make sure we ignore them here too?
https://github.com/chainloop-dev/chainloop/blob/main/.gitattributes
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds a plugin to generate json schemas based on the
protodefines in the code. Since we are only interested in the ones aboutworkflowcontracts, I've modified the Make file to get rid of those unwanted files.