feat: require project name on workflow management #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
migmartri
commented
Oct 9, 2024
| PreRunE: func(cmd *cobra.Command, _ []string) error { | ||
| if workflowName == "" { | ||
| return errors.New("workflow name is required, set it via --name flag") | ||
| return errors.New("workflow name is required, set it via --workflow flag") |
Member
Author
There was a problem hiding this comment.
I got some feedback from @juamedgod that --name was confusing since it seemed the name of the attestation itself.
So I have changed it to workflow while keeping the existing --name as deprecated
| cmd.Flags().StringVar(&workflowName, "name", "", "name of the workflow to run the attestation") | ||
|
|
||
| cobra.CheckErr(cmd.Flags().MarkDeprecated("name", "please use --workflow instead")) | ||
| cmd.Flags().StringVar(&projectName, "project", "", "name of the project of this workflow") |
Member
Author
There was a problem hiding this comment.
project is not yet fully enforced in the attestation init
| cobra.CheckErr(cmd.MarkFlagRequired("name")) | ||
|
|
||
| cmd.Flags().StringVar(&projectName, "project", "", "project name") | ||
| cobra.CheckErr(cmd.MarkFlagRequired("project")) |
Member
Author
There was a problem hiding this comment.
but it is in the rest of the APIs.
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
migmartri
force-pushed
the
1375-warn-user
branch
from
b3cb901 to
7740cfa
Compare
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
jiparis
approved these changes
Oct 10, 2024
| gt.AppendRow(table.Row{"Attestation ID", status.AttestationID}) | ||
| gt.AppendRow(table.Row{"Organization", meta.Organization}) | ||
| gt.AppendRow(table.Row{"Name", meta.Name}) | ||
| gt.AppendRow(table.Row{"Team", meta.Team}) |
Member
There was a problem hiding this comment.
Are we removing team in the future?
Member
Author
There was a problem hiding this comment.
Not really, but I see no value in showing it, not sure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step towards #1375 it
attestation initwith an optional--projectflag so we can cut a release and prepare our clients (and dagger module) for a switch.