Skip to content

Conversation

@migmartri
Copy link
Member

@migmartri migmartri commented Dec 9, 2024

new set of events for org management

  • orgCreate
  • orgInvite
  • OrgJoined
  • OrgLeft

image

This PR also adds some logic to allow event publishers to define if the event must contain actor or not. That way the system will not send events that do not have the full context

refs #1628

@migmartri migmartri requested review from javirln and jiparis December 9, 2024 19:23
Copy link
Member

@javirln javirln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

}

// user got invited to the organization
type OrgUserInvited struct {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we place here who invited the user as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is the actor, see the description of the evetn

TargetID() *uuid.UUID
// Description returns a templatable string, see the DescriptionVariables struct.
Description() string
RequiresActor() bool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok I haven't seen this!

Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
Signed-off-by: Miguel Martinez <miguel@chainloop.dev>
@migmartri migmartri merged commit a160509 into chainloop-dev:main Dec 10, 2024
13 checks passed
@migmartri migmartri deleted the expose-vars branch December 10, 2024 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants