chore(pkg): Only download material if 200 #1871
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
approved these changes
Mar 3, 2025
migmartri
approved these changes
Mar 3, 2025
| defer resp.Body.Close() | ||
|
|
||
| // Check if the response is OK | ||
| if resp.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
what about redirections, should we follow them?
There was a problem hiding this comment.
I've added a comment about that. By default the http.Get performs a maximum of 10 redirections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes an improvement to the
loadFromURLfunction in thepkg/resourceloader/resourceloader.gofile. The change ensures better error handling when loading content from a URL.Improvements to error handling:
pkg/resourceloader/resourceloader.go: Added a check to ensure the HTTP response status is OK before attempting to read the response body. If the status is not OK, an error is returned with the status message.