Skip to content

chore(pkg): Only download material if 200 #1871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2025
Merged

chore(pkg): Only download material if 200 #1871

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/resourceloader/resourceloader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,13 +73,19 @@ func loadResourceFromURLOrEnv(resourcePath string) ([]byte, error) {
// loadFromURL loads the content of a URL and returns it as a byte slice.
func loadFromURL(url string) ([]byte, error) {
// As cosign does: https://github.com/sigstore/cosign/blob/beb9cf21bc6741bc6e6b9736bdf57abfb91599c0/pkg/blob/load.go#L47
// By default it will attempt a maximum 10 redirects
// #nosec G107
resp, err := http.Get(url)
if err != nil {
return nil, fmt.Errorf("requesting URL: %w", err)
}
defer resp.Body.Close()

// Check if the response is OK
if resp.StatusCode != http.StatusOK {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about redirections, should we follow them?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a comment about that. By default the http.Get performs a maximum of 10 redirections

return nil, fmt.Errorf("loading URL: %s", resp.Status)
}

raw, err := io.ReadAll(resp.Body)
if err != nil {
return nil, fmt.Errorf("loading URL response: %w", err)
Expand Down
Loading