fix: Store DSSE envelope when bundle is not available #1907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Mar 18, 2025
| SetAttestationDigest(digest) | ||
| if att != nil { | ||
| // Set attestation when using old CLI versions | ||
| q.SetAttestation(att) |
Member
There was a problem hiding this comment.
but I thought that we wanted to store always bundle. Didn't we end up doing some sort of automatic wrapping on a bundle?
Member
Author
There was a problem hiding this comment.
We could. But even if we do it, old attestations must still be supported
migmartri
approved these changes
Mar 18, 2025
| q := r.data.DB.WorkflowRun.UpdateOneID(id). | ||
| SetAttestationDigest(digest) | ||
| if att != nil { | ||
| // Set attestation when using old CLI versions |
Member
There was a problem hiding this comment.
ok, so make it even more obvious that this is a deprecated behavior
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using old CLI versions, only DSSE envelope is available. There is a bug introduced in #1890 that prevents it from being stored in the WorkflowRun table. This PR fixes it, so that it's backwards compatible.