fix(policy): Fix policy script loading for HTTP/HTTPS URLs #2589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
javirln
changed the title
jiparis
approved these changes
Nov 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug in
loadPolicyScriptandloadLegacyPolicyScriptfunctions where thesource.pathfield was always treated as a file path, even when it contained an HTTP or HTTPS URL.According to the protobuf definition, the
pathfield can be a URI reference, but the code was incorrectly usingfilepath.Joinon all paths, which corrupted URLs by treating them as relative file paths.Changes
isURLPathhelper function to detect HTTP/HTTPS URLs using the existingRefPartsutilityloadPolicyScriptto handle URLs directly without path joiningloadLegacyPolicyScriptwith the same fix for backward compatibilityThe fix maintains backward compatibility with relative and absolute file paths while properly handling remote policy references via HTTP/HTTPS.