chore(signing): verify signature on att push #2606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
reviewed
Dec 5, 2025
| } | ||
|
|
||
| // verify attestation (only if chainloop is the signer) | ||
| result, err := uc.verifyBundle(ctx, rawContent) |
Member
There was a problem hiding this comment.
where is the logic that makes sure the bundle is verified when keyless signing was used?
migmartri
approved these changes
Dec 5, 2025
|
|
||
| func (uc *WorkflowRunUseCase) Verify(ctx context.Context, run *WorkflowRun) (*VerificationResult, error) { | ||
| func (uc *WorkflowRunUseCase) VerifyRun(ctx context.Context, run *WorkflowRun) (*VerificationResult, error) { | ||
| return uc.verifyBundle(ctx, run.Attestation.Bundle) |
Member
There was a problem hiding this comment.
is there any case where run.Attestation would be empty?
Member
There was a problem hiding this comment.
it seems it will not, makes sense.
| } | ||
|
|
||
| // if it's verifiable, make sure it passed | ||
| if result != nil && !result.Result { |
Member
There was a problem hiding this comment.
oh, so result will be nil if can't be verified? I'd make it more explicit somehow
Member
Author
There was a problem hiding this comment.
yes in that case it would return nil, nil. I agree it should return something more explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change ensures that the attestation bundle is verified on attestation push, failing if the signature is not recognized (only when chainloop is the signer)