feat(contract): change apply response from unchanged to changed#2833
Merged
Piskoo merged 4 commits intochainloop-dev:mainfrom Mar 10, 2026
Merged
feat(contract): change apply response from unchanged to changed#2833Piskoo merged 4 commits intochainloop-dev:mainfrom
Piskoo merged 4 commits intochainloop-dev:mainfrom
Conversation
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
There was a problem hiding this comment.
2 issues found across 11 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="app/controlplane/internal/service/workflowcontract.go">
<violation number="1" location="app/controlplane/internal/service/workflowcontract.go:280">
P1: `Apply` returns `changed=false` on contract creation because the create-path response does not set `Changed`. This inverts the intended positive semantics for newly created contracts.</violation>
</file>
<file name="app/cli/pkg/action/workflow_contract_apply.go">
<violation number="1" location="app/cli/pkg/action/workflow_contract_apply.go:69">
P1: The `changed` semantic update is incomplete: create still returns `false`, so successful contract creation is incorrectly reported as not changed.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Signed-off-by: Sylwester Piskozub <sylwesterpiskozub@gmail.com>
migmartri
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the apply endpoint response field from bool unchanged to bool changed to use positive semantics.. Updates proto definition, business logic, service layer, and CLI commands accordingly.