fix: return early in DiscoverRunner on first match#2871
Merged
jiparis merged 1 commit intochainloop-dev:mainfrom Mar 19, 2026
Merged
fix: return early in DiscoverRunner on first match#2871jiparis merged 1 commit intochainloop-dev:mainfrom
jiparis merged 1 commit intochainloop-dev:mainfrom
Conversation
Stop iterating through all runner factories after the first matching runner is found. This avoids unnecessary CheckEnv() calls from remaining runners as more runner implementations are added. Fixes chainloop-dev#2834 Signed-off-by: Vibhav Bobade <vibhav.bobde@gmail.com>
waveywaves
force-pushed
the
fix/runner-discovery-early-return
branch
from
76988bb to
b486f4e
Compare
waveywaves
changed the title
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Author
|
cc @jiparis |
Member
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
jiparis
approved these changes
Mar 19, 2026
Member
jiparis
left a comment
jiparis
left a comment
There was a problem hiding this comment.
Awesomw, thanks @waveywaves !
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DiscoverRunnerafter the first match — return it immediately instead of collecting all matches into a sliceCheckEnv()calls from remaining runners, which becomes more impactful as more runner implementations are addedFixes #2834