fix(cli): handle inline PEM CA content in artifact download#3013
Merged
javirln merged 1 commit intochainloop-dev:mainfrom Apr 9, 2026
Merged
fix(cli): handle inline PEM CA content in artifact download#3013javirln merged 1 commit intochainloop-dev:mainfrom
javirln merged 1 commit intochainloop-dev:mainfrom
Conversation
The artifact download command unconditionally passed the CAS CA config value to WithCAFile(), which fails with "file name too long" when the value contains inline PEM content instead of a file path. Use os.Stat() to distinguish paths from PEM content, matching the existing pattern in root.go and action.go. Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The artifact download command unconditionally passed the CAS CA config value to
WithCAFile(), which callsos.ReadFile()and fails with "file name too long" when the config contains inline PEM content (as set by the enterprise install script) instead of a file path.This applies the same
os.Stat()check already used inroot.goandaction.goto distinguish file paths from inline PEM content, routing toWithCAFileorWithCAContentaccordingly.