fix(crafter): resolve commit info in git worktrees#3020
Merged
jiparis merged 1 commit intochainloop-dev:mainfrom Apr 10, 2026
Merged
fix(crafter): resolve commit info in git worktrees#3020jiparis merged 1 commit intochainloop-dev:mainfrom
jiparis merged 1 commit intochainloop-dev:mainfrom
Conversation
Enable EnableDotGitCommonDir in go-git PlainOpenOptions so that worktree directories can properly resolve HEAD via .git/commondir. Closes chainloop-dev#3018 Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
60a51c9 to
1aed8ce
Compare
migmartri
approved these changes
Apr 10, 2026
javirln
approved these changes
Apr 10, 2026
Member
Author
Probably not. It was a missing configuration in the library. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnableDotGitCommonDirin go-git'sPlainOpenOptionsso that git worktrees can properly resolve HEAD via.git/commondirchainloop att initfrom a worktree returned no commit info because go-git couldn't follow the commondir reference to resolve HEADCloses #3018