feat(docs): Document Ory Hydra as OAuth2 provider #843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
migmartri
approved these changes
May 29, 2024
|
|
||
| Relevant information that can be noted from the command signature is: | ||
| - `name`: The name of the OAuth2 client | ||
| - `grant-type`: The grant type of the client it needs to be set `authorization_code` and `refresh_token` |
Member
There was a problem hiding this comment.
do we need refresh token? I do not think so.
Member
There was a problem hiding this comment.
Not sure about dex but Auth0, which we use in prod seems to by default indeed add refresh_token. I guess it's fine although I do not think we keep any kind of refresh token in the client, we could potentially disable that grant and should be fine.
For now, until we test that, I'd leave it as is
Thanks
Update adding link https://auth0.com/docs/get-started/applications/application-grant-types#public-applications
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds documentation regarding the configuration needed to use Ory Hydra as OAuth2 provider.
Closes #829