Skip to content

Conversation

@javirln
Copy link
Member

@javirln javirln commented Jun 4, 2024

This patch drops support for Chainloop Robot Accounts in favor of API Tokens by using the env variable CHAINLOOP_TOKEN. It additionally performs the following changes:

  • Bump version of Chainloop CLI to ensure latest compatibility
  • Bump reusable workflows to their latest version available on Chainloop's labs

@javirln javirln requested review from jiparis and migmartri June 4, 2024 09:21
@javirln javirln changed the title Feat/731 remove robot accounts feat(workflows-chainloop): Consolidates robot accounts into API token Jun 4, 2024
@javirln javirln marked this pull request as draft June 4, 2024 10:53
@javirln
Copy link
Member Author

javirln commented Jun 4, 2024

Reusable workflows needs to be updates in order to accept an API Token as input through CHAINLOOP_TOKEN.

Refs chainloop-dev/labs#22

@javirln
Copy link
Member Author

javirln commented Jun 4, 2024

Reusable workflows need to allow to pass down the workflow name required by API tokens: chainloop-dev/labs#24

@javirln
Copy link
Member Author

javirln commented Jun 4, 2024

This PR needs changes on this merged one #874 to be deployed so the remote state can work properly using API tokens.

@javirln
Copy link
Member Author

javirln commented Jun 5, 2024

Scorecard workflow is working with the changes regarding the attestation however, it's failing due failure on the generation of reports: https://github.com/chainloop-dev/chainloop/actions/runs/9381594534/job/25831213115

I haven't touch anything regarding that part, only bump the version of the associated reusable workflows.

@javirln
Copy link
Member Author

javirln commented Jun 5, 2024

The issue is that the chainloop_push reusable workflow is expecting a file that we are not generating anymore. We are adding a condition there.

cc @jiparis

Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
@javirln javirln force-pushed the feat/731-remove-robot-accounts branch from 740d208 to ca80f08 Compare June 5, 2024 12:17
@javirln javirln marked this pull request as ready for review June 5, 2024 12:17
Copy link
Member

@migmartri migmartri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@javirln javirln merged commit 8e36e9f into main Jun 5, 2024
@javirln javirln deleted the feat/731-remove-robot-accounts branch June 5, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants