-
Notifications
You must be signed in to change notification settings - Fork 41
feat(keyless): add keyless config to deployment template #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
|
thanks! It would be great if you could show a diff of doing a |
migmartri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first, it looks good to me!
We are missing though a section in the readme documenting this feature. Like Enable Keyless signing using local file CA or smth like that. You can see in the readme examples of excerps of snippets about enabling different features.
Please do not merge until we double check that there is no render problem.
Another thing you need to do is to bump the chart version (patch version)
chainloop/deployment/chainloop/Chart.yaml
Lines 6 to 7 in 65be1d6
| # Bump the patch (not minor, not major) version on each change in the Chart Source code | |
| version: 1.52.0 |
Sure, let me ammend some changes. |
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
Signed-off-by: Jose I. Paris <jiparis@chainloop.dev>
migmartri
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
deployment/chainloop/README.md
Outdated
|
|
||
| ### Deploy in keyless mode with file-based CA | ||
|
|
||
| *This feature is experimental, as it doesn't still support verification.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/still/yet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😞 those false friends ...
This PR adds the secrets and configuration to support keyless signing in the K8s deployment.
Before and after applying keyless configuration in values.yaml
Refs #865