Skip to content

remove robot-account from CLI #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
migmartri merged 4 commits into from
Jun 5, 2024
Merged

remove robot-account from CLI #894

migmartri merged 4 commits into from
Jun 5, 2024

Conversation

@migmartri
Copy link
Member

@migmartri migmartri commented Jun 5, 2024

  • remove robot-account command, references and support from the CLI
  • improvements on message, for example
ERR Chainloop Token required, please provide it via --token flag or CHAINLOOP_TOKEN environment variable

Refs #891

migmartri added 2 commits June 5, 2024 15:00
@migmartri
refactor: deprecate robot-account in CLI
c9613bc 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
refactor: deprecate robot-account in CLI
f233c43 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri migmartri requested review from javirln and jiparis June 5, 2024 13:06
migmartri added 2 commits June 5, 2024 15:07
@migmartri
refactor: deprecate robot-account in CLI
a4c9016 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
@migmartri
refactor: deprecate robot-account in CLI
1390b9b 
Signed-off-by: Miguel Martinez Trivino <miguel@chainloop.dev>
jiparis
jiparis approved these changes Jun 5, 2024
View reviewed changes
Copy link
Member

@jiparis jiparis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🚀

@migmartri migmartri merged commit d1e1776 into chainloop-dev:main Jun 5, 2024
@migmartri migmartri deleted the deprecate-robot-account-command branch June 5, 2024 14:09
@BrewTestBot BrewTestBot mentioned this pull request Jun 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jiparis jiparis jiparis approved these changes

@javirln javirln javirln approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@migmartri @jiparis @javirln