feat(chart): Replace Vault dependency to use Bitnami chart #935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
jiparis
approved these changes
Jun 11, 2024
migmartri
approved these changes
Jun 11, 2024
Signed-off-by: Javier Rodriguez <javier@chainloop.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces the Hashicorp Vault dependency with Bitnami's version of Vault to align with their CONTRIBUTING guidelines.
The primary difference between the old and new Chart is the support for development mode in Vault, particularly for local development instances. Bitnami's chart is sufficiently flexible, allowing us to enable development mode by adjusting a few options, such as the default
argsof the server andextraEnvVars.Additionally, this patch includes the addition of license headers and updates the Chart.yaml version and executed Bitnami's README generator tool.