Adding more integration tests and refactoring #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
danlishka
force-pushed
the
integration_tests
branch
from
c8ab04d to
e4d9ee7
Compare
Signed-off-by: Daniel Liszka <daniel@chainloop.dev>
migmartri
approved these changes
Jun 7, 2024
| DIR="$( cd "$( dirname "${BATS_TEST_FILENAME}" )/.." >/dev/null 2>&1 && pwd )" | ||
| PATH="$DIR/:$PATH" | ||
| export PATH="$DIR/:$PATH:/usr/local/bin/chainloop_bin" | ||
| export DO_NOT_TRACK=1 |
Member
There was a problem hiding this comment.
thanks!
and btw, what organization are you running these tests against? cc/ @javirln
|
|
||
| # Abats test_tags=bats:focus | ||
| @test "full attestation flow" { | ||
| export CHAINLOOP_WORKFLOW_NAME="chainloop-labs-tests" |
Member
There was a problem hiding this comment.
is this env variable something that the chainloop_attestation_init wrapper understands? I am asking because we've removed a similar (or same) env variable from the init command itself in the CLI.
Member
Author
There was a problem hiding this comment.
yes, this is in the wrapper added by @javirln at some point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the end-to-end tests with KMS and autogenerated keys. All tests were conducted on Alpine, Ubuntu, and UBI9.