fix: websocket deadlock for high amounts of concurrency #141
+164
−133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koraykoska
added a commit
that referenced
this pull request
Aug 1, 2023
* fix: send websocket request only when promise was set * fix: only decode once for path decision * fix: concurrency issue with websocket send * fix: websocket wait for response before continuing * fix: async exec receive ws messages * fix: increase max frame size * fix: single threaded ws group * fix: sometimes websocket was not initialized * fix: revert to 4 threads * fix: avoid deadlock by having multiple seperate queues * fix: switch from semaphores to closures * fix: do not send from queue * fix: do not access synchronized array synchronously
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For whatever reason WebSocket connections when used in highly concurrent applications generated pseudo deadlocks and waited ~4 seconds per request to process them. This PR fixes this issue by utilizing a non-blocking methodology of parallel computing (e.g.: completion handlers).