-
Notifications
You must be signed in to change notification settings - Fork 6
feat: INFRA-5050 BSC image upgrade v1.5.19 #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Dmitrii Spichakov <dmitrii.spichakov@chainstack.com>
WalkthroughThe Dockerfile has been updated to download version Changes
Sequence Diagram(s)Not applicable: The change is limited to updating a version number in a Dockerfile and does not affect control flow or introduce new features. Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
Dockerfile (2)
4-4: Parameterise the version for painless future upgradesHard-coding
v1.5.19within the RUN line requires manual editing each bump. Using anARG BSC_VERSION(see diff above) decouples the version from the command and simplifies CI-driven upgrades.
3-3: Shrink image size by cleaningaptcacheThe current
apt-getinvocation leaves/var/lib/apt/listsin the layer (~20 MB). Addrm -rf /var/lib/apt/lists/*(already shown in the diff) or combine with--no-install-recommendsto keep the image lean.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
Dockerfile(1 hunks)
🧰 Additional context used
🪛 Checkov (3.2.334)
Dockerfile
[HIGH] 4-4: Ensure that certificate validation isn't disabled with wget
(CKV2_DOCKER_3)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: guardrails/scan
BSC image upgrade v1.5.19
INFRA-5050 Bsc v1.5.19 Upgrades across clusters
Summary by CodeRabbit