Closed
Conversation
Replaced `Byte` with `uint8_t` for better clarity and standardization
Replaced `Byte` with `uint8_t` for better clarity and standardization
Introduced a `PortableMidiPacket` abstraction to unify MIDI packet handling across platforms, replacing platform-specific logic.
Closed
Owner
Author
|
closing as im rebasing against upstream main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement cross-platform midi support via RtMidi. Using a similar pattern as the cross-platform file handling, a "PortableMidiClient" and "PortableMidiPacket" helps to encapsulate the platform-specific differences.
Adds tests for midi packet handling. Ideally we'd also test the midi interaction itself but I'm not sure there's going to be a way to do that that's worth the effort currently.