About the 0.4.6 pull requests showing as closed instead of merged

[chaitanyagiri]

If you sent us a pull request that went into 0.4.6 and you are looking at it right now showing "Closed" instead of "Merged", that is on us. I want to explain exactly what happened, because the explanation matters and "closed" reads like we did not want your work.

We used your work. It is in main. What we got wrong was the order we did things in.

What happened

GitHub only marks a pull request as merged when your commit lands in the branch the PR points at. On release night we ran two jobs at the same time that should have run one after the other. The pull requests got closed at 01:15 UTC. The release got merged into main after that. So at the moment we closed them, main did not contain your commits yet, GitHub saw them as unmerged, and closing froze them that way.

It was a time constraint and it was our own negligence in how we sequenced it. Nobody caught it before it was permanent.

I tried to undo it. GitHub will not let you. Reopening comes back with "state cannot be changed, these commits are already merged", which is GitHub telling us it knows your commits are merged while still refusing to move the badge. There is no API that sets it either. So for 0.4.6 this cannot be fixed, and I would rather say that plainly than quietly leave it.

Your commits are in main, with your name on them

You can check any of these yourself:

PR	Contributor	Commit in main
#156	@gpechieu	ed8bc84f
#205	@lukatao	9550dd74
#225	@jhinzzz	7b570c2c
#242	@raifemre	b01770e4
#243	@L422Y	9edf34ea
#248	@djbiz	1155c344
#270	@BUGHUNTER-SACHIN	ee806756
#271	@HsienW	6446a8d8
#282	@savvaskoualis	c461fe1a
#284	@HundredBillion	268ec1b8
#286	@HundredBillion	94a03bb8
#310	@LavaDMan	4cdd0393
#317	@aaroncoville	2b96d5d0
#323	@aaroncoville	e6c936ac

Two more that need their own note:

@abo123v-glitch, your Arabic and RTL work in #213 shipped as three files carried over byte for byte, in commits 59d721ed and 6f7ffb89. Those commits are authored by us and not by you, and that was the wrong call. The rest of the branch got rebuilt around a language gate so it could not merge as it stood. 0.4.6 speaks Arabic because of you.

@aaroncoville, #339 is partly in and the branch still carries work we have not taken. #318 is still open on purpose. We used your diagnosis there and not your patch, and we should have said so at the time.

Most of you already show on the contributors page for this repo and those commits count on your GitHub profile.

@jhinzzz and @aaroncoville, yours do not, and it is fixable by you in about a minute. Your commits are in main under your name, but the email address on them is not linked to your GitHub account, so GitHub is not connecting them to you. Add that email in your GitHub email settings and it credits you retroactively. Nothing needed from us.

Also thank you

@Maev4l, #168 shipped and sat open far longer than it should have. #170 is still open and we have not reviewed it properly yet, which is our backlog and not a verdict on the work.

@HaningZS, #172 is still open. Two of your three commits shipped, the third is a real fix we have not taken yet.

What changes

We merge into main first and close after, and we merge through GitHub so the badge sets itself. That is the entire fix. It costs nothing, it should have been how we did it the first time, and it will not happen again from the next release on.

A merged PR is not decoration. It is on your profile, it is what people look at when they are deciding whether you are worth hiring or collaborating with, and it is the normal way open source says thank you. We took that from 23 pull requests through carelessness and we cannot give it back for this one.

0.4.6 has 16 contributions from 13 people in it. It is a better release than we would have shipped on our own, and the parts people are actually talking about, the app speaking Chinese and Arabic, came from you and not from us.

Thank you. Genuinely.

Chaitanya