This repository was archived by the owner on Jan 23, 2024. It is now read-only.
fix(react-live-block): allow horizontal scroll of preview in mobile screens #496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…odePreview` baseStyle
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-docs/BfotJmEiRHrs3Y4xM3mGbaZGV1yz |
|
@nikolovlazar this is good to go for review! |
noobinthisgame
approved these changes
Apr 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
overflowX: autoandwhiteSpace: preare applied to theLiveCodePreviewcomponent to constrain the live code examples within the preview container, allow for horizontal scroll, and preserve the intended white space from the example.⛳️ Current behavior (updates)
Some current live previews are overflowing the preview container when viewed in a mobile device, breaking the page layout.
🚀 New behavior
Hide the overflow and allow for horizontal scrolling with
overflowX: autoapplied to theLiveCodePreviewcomponent.Also apply
whiteSpace: preto preserve white space of any text content and prevent the text from getting compressed, depending on the created code example.💣 Is this a breaking change (Yes/No):
No
📝 Additional Information
This PR provides a simpler, more global, and less confusing fix than PR #488.