This repository was archived by the owner on Jan 23, 2024. It is now read-only.
fix(react-live-block): remove whiteSpace: pre from LiveCodePreview baseStyle
#518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/chakra-ui/chakra-ui-docs/J53iW5JcQQNRAo6EvZ4RvCBsQUKr |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #505
📝 Description
With the merge of PR #496 the intended purpose of including
whiteSpace: prewith the addition ofoverflowX: autoin theLiveCodePreviewcomponent was to retain white-space when horizontal scroll occurs in live code example previews, so text content was not compressed. Unfortunately, an overlooked side effect is other previously unaffected examples forcing text content out of view with no ability to scroll, or creating new overflow. This PR simply removes thewhiteSpaceprop⛳️ Current behavior (updates)
Examples like those in the
Alertdocs have text content forced out of view in the preview window and no ability for horizontal scroll.Examples like the
Popoverbasic usage have text content that overflows their parent components.🚀 New behavior
Examples that had parent component with relative width values will allow the text content to wrap and stay within the initial view of the container
💣 Is this a breaking change (Yes/No):
No