Skip to content

Conversation

@shobhitsinghal624
Copy link
Member

Original source: mastermoo#373

Improving filter because if children is rendering with a condition ex.:

{callcenter_phone ? (
        <ActionButton.Item
          onPress={handleOpenCall}
          buttonColor={childrenColor || theme.colors.primary}
        >
          <Icon name="phone" type="FontAwesome" />
        </ActionButton.Item>
) : null}

It pass in filter because typeof null is 'object'

This PR closes mastermoo#366

@shobhitsinghal624 shobhitsinghal624 merged commit fbc684b into chakrahq:master Sep 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot read property 'props' of null

2 participants