Skip to content

Conversation

@carlangas159
Copy link
Contributor

GDPR fields titles in Terms and Conditons should be invisbile if there is no content - ref #3437

@carlangas159
Copy link
Contributor Author

GDPR fields titles in Terms and Conditons should be invisbile if there is no content - ref #3437

image

@FlintCIBot
Copy link

Lint errors were found. A patch is also available.

Please see the report: https://flintci.io/repositories/1013/analyses/39121

This comment was posted by FlintCI. It can be disabled in the repository settings.

@ywarnier ywarnier requested a review from NicoDucou August 10, 2020 23:50
@ywarnier
Copy link
Member

@NicoDucou this change seems rather simple. Could you check it on a system with GDPR items already set? (and also check why in Carlos' screenshot, there is an untranslated term - is this one missing?)

@ywarnier ywarnier added this to the 1.11.12 milestone Aug 10, 2020
@NicoDucou
Copy link
Member

The change is correct and it works fine with already set GDPR content and without content.
For the translation, it's because of a missing get_lang so none of the title where translated.
I accept this PR and then I correct the get_lang issue.

@NicoDucou NicoDucou merged commit 9c8e16b into chamilo:1.11.x Aug 11, 2020
NicoDucou added a commit that referenced this pull request Aug 11, 2020
@NicoDucou
Copy link
Member

Fixed with commit 107d15f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants