Skip to content

Admin: Guard unknown settings categories #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Admin: Guard unknown settings categories #6993

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/CoreBundle/Controller/Admin/SettingsController.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,16 @@ public function searchSetting(Request $request, AccessUrlHelper $accessUrlHelper
$templateMapByCategory[$category][$var] = $templateMap[$var];
}
}
$settings = $manager->load($category);

// Convert category to schema alias and validate it BEFORE loading/creating the form
$schemaAlias = $manager->convertNameSpaceToService($category);

// skip unknown/legacy categories (e.g., "tools")
if (!isset($schemas[$schemaAlias])) {
continue;
}

$settings = $manager->load($category);
$form = $this->getSettingsFormFactory()->create($schemaAlias);

foreach (array_keys($settings->getParameters()) as $name) {
Expand Down Expand Up @@ -147,6 +155,17 @@ public function updateSetting(Request $request, AccessUrlHelper $accessUrlHelper
$schemaAlias = $manager->convertNameSpaceToService($namespace);

$keyword = (string) $request->query->get('keyword', '');

// Validate schema BEFORE load/create to avoid NonExistingServiceException
$schemas = $manager->getSchemas();
if (!isset($schemas[$schemaAlias])) {
$this->addFlash('warning', sprintf('Unknown settings category "%s". Showing Platform settings.', $namespace));

return $this->redirectToRoute('chamilo_platform_settings', [
'namespace' => 'platform',
]);
}

$settings = $manager->load($namespace);

$form = $this->getSettingsFormFactory()->create(
Expand Down Expand Up @@ -193,7 +212,6 @@ public function updateSetting(Request $request, AccessUrlHelper $accessUrlHelper
]);
}

$schemas = $manager->getSchemas();
[$ordered, $labelMap] = $this->computeOrderedNamespacesByTranslatedLabel($schemas, $request);

$templateMap = [];
Expand Down
Loading